Fix: Implement one _refresh_memory_dict() function #902

jan-janssen · 2026-02-09T18:57:17Z

Summary by CodeRabbit

Refactor
- Internal improvements to task scheduling logic with no external behavior changes.

coderabbitai · 2026-02-09T18:59:29Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes introduce two helper functions (_refresh_memory_dict and _cancel_processes) that consolidate repeated logic in the task scheduler's execute_tasks_h5 function. A test utility function is added for long-running test scenarios.

Changes

Cohort / File(s)	Summary
Task scheduler refactoring `src/executorlib/task_scheduler/file/shared.py`	Extracted `_refresh_memory_dict()` and `_cancel_processes()` helper functions to consolidate dictionary refresh and process termination logic previously inline in execute_tasks_h5, centralizing control flow without altering external behavior.
Test utilities `tests/unit/executor/test_flux_cluster.py`	Added `long_running_function()` test helper that sleeps for 10 seconds to support long-running test scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 With helpers refined and logic made neat,
Process management skips and dances complete,
Memory dances, cancellations take flight,
Tests run long and steady through the night! ✨

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch refresh_memory_dict

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2026-02-09T19:00:04Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

 ___________________________________
< Tom & Jerry level of bug chasing. >
 -----------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

_{✏️ Tip: You can disable in-progress messages and the fortune message in your review settings.}

Tip

You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting to assertive to make CodeRabbit's nitpick more issues in your PRs.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch refresh_memory_dict

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2026-02-09T19:01:37Z

📝 Walkthrough

Walkthrough

A helper function _refresh_memory_dict() was introduced to consolidate repeated inline memory dictionary refresh logic that appeared across three code paths. Previously, each location used dict comprehensions calling _check_task_output; now all three invoke the new centralized helper, eliminating duplication while maintaining identical behavior.

Changes

Cohort / File(s)	Summary
Memory Dictionary Refresh Refactoring `src/executorlib/task_scheduler/file/shared.py`	Extracted repeated inline dict comprehension logic into new `_refresh_memory_dict()` helper function. Helper is invoked in three previously duplicated code paths that refresh memory dictionaries by filtering completed futures. Semantic behavior unchanged; logic consolidated for maintainability.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Three paths became one, the code whispered with glee,
No more repetition, just helpers so free,
Memory dicts refresh with elegance bright,
Refactored and tidy, everything right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: implementing a new helper function _refresh_memory_dict() to consolidate repeated logic, which is the primary objective of this refactoring PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch refresh_memory_dict

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/executorlib/task_scheduler/file/shared.py (1)
265-274: Good DRY refactor consolidating the repeated dict comprehension.

The extraction is clean and the behavior is preserved. One optional suggestion: add a brief docstring for consistency with the other private helpers in this file (e.g., _check_task_output, _convert_args_and_kwargs).
📝 Optional: add docstring
 def _refresh_memory_dict(memory_dict: dict, cache_dir_dict: dict) -> dict:
+    """
+    Refresh memory_dict by checking task outputs and removing completed futures.
+
+    Args:
+        memory_dict (dict): Mapping of task keys to their associated future objects.
+        cache_dir_dict (dict): Mapping of task keys to their cache directories.
+
+    Returns:
+        dict: Updated memory_dict with only pending (not done) futures.
+    """
     return {
         key: _check_task_output(

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

for more information, see https://pre-commit.ci

…hub.com:pyiron/executorlib into refresh_memory_dict

codecov · 2026-02-12T18:36:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.61%. Comparing base (7e68730) to head (44ff716).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
+ Coverage   93.60%   93.61%   +0.01%     
==========================================
  Files          38       38              
  Lines        1891     1895       +4     
==========================================
+ Hits         1770     1774       +4     
  Misses        121      121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

for more information, see https://pre-commit.ci

Fix: Implement one _refresh_memory_dict() function

c6c2945

jan-janssen marked this pull request as draft February 9, 2026 19:00

jan-janssen and others added 7 commits February 9, 2026 20:30

Add _cancel_processes()

b0255c1

Format black

7910aca

mypy fixes

0502bc7

[pre-commit.ci] auto fixes from pre-commit.com hooks

866e3f6

for more information, see https://pre-commit.ci

more fixes

3f54559

Merge branches 'refresh_memory_dict' and 'refresh_memory_dict' of git…

e4910bd

…hub.com:pyiron/executorlib into refresh_memory_dict

Merge branch 'main' into refresh_memory_dict

e4d0240

jan-janssen and others added 16 commits February 12, 2026 19:49

add more tests

f4600e3

fix

facb353

long running task

3233271

sleep

a323735

use context

fc92d06

use long running function

ca5da07

fix file count

0c67872

cancel

76d2b6b

everything as it should

e0c7b21

do not cancel

c526291

not cancelled

3d6be51

no wait

024e35a

sleep again

5e1d637

fixes

56e9da0

[pre-commit.ci] auto fixes from pre-commit.com hooks

343c957

for more information, see https://pre-commit.ci

Merge branch 'main' into refresh_memory_dict

44ff716

jan-janssen marked this pull request as ready for review February 13, 2026 06:35

jan-janssen merged commit aa0f602 into main Feb 13, 2026
87 of 91 checks passed

jan-janssen deleted the refresh_memory_dict branch February 13, 2026 06:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Implement one _refresh_memory_dict() function #902

Fix: Implement one _refresh_memory_dict() function #902

jan-janssen commented Feb 9, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 9, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai bot commented Feb 9, 2026

Uh oh!

coderabbitai bot commented Feb 9, 2026

Walkthrough

Changes

Estimated code review effort

Poem

Review ran into problems

Uh oh!

codecov bot commented Feb 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix: Implement one _refresh_memory_dict() function #902

Fix: Implement one _refresh_memory_dict() function #902

Conversation

jan-janssen commented Feb 9, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai bot commented Feb 9, 2026

Uh oh!

coderabbitai bot commented Feb 9, 2026

Walkthrough

Changes

Estimated code review effort

Poem

Review ran into problems

Uh oh!

codecov bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jan-janssen commented Feb 9, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 12, 2026 •

edited

Loading